Faciliate Painworking not working - REASON INCLUDED

Started 20 Oct 2019
by Strikejk
in Resolved Issues
Faciliate Painworking isn't working sometimes and after researching it extensively and testing it I finally figured out why.
I will include easy to understand pictures in a link at the bottom but here is a quick rundown on whats happening.
1. A spell on the necro is split up into 3 parts.
Part 1: The shade spell queue (can be 0s)
Part 2: The pet spell queue (can be 0s)
Part 3: The spell being fired by the pet

Part 3 is where the bug happens.

If two spells are fired at the exact same time, for example the healing spell Imbue the Abyss and Facilitate Painworking one will block the others from being "fired" by the pet. Because Faciliate Painworking works instantly and doesn't go "into the queue" as far as I could tell it can not be fired *together* or rather in sequence of the healing spell which was casted by the shade.
This only happenes if the timing is exactly overlapping hence the rarity of this bug. Imbue of the Abyss has to be casted multiple seconds earlier and be fired by the pet exactly when you press facilitate painworking for this bug to occur.

It does not happen with other spells than facilitate painworking to my knowledge because all other spells are normal spells that go into the queue and thus are fired together (actually in sequence but at pretty much the same time).

If this was too confusing look at the pictures below. They showcase the different spells and their 3 parts (If they have 3 parts otherwise just 2). This is not the only example picture I have but merely the only one I wanted to waste my time with paint. They all share the same pattern of the missing/overlapping cast by the pet.

https://imgur.com/a/uGl3xQl

Issue Timeline

20 Oct 2019 Strikejk created this issue
22 Oct 2019 gruenesschaf assigned this issue from Nobody to gruenesschaf
25 Oct 2019 gruenesschaf changed the status of this issue from in_progress to resolved
Sun 20 Oct 2019 8:20 PM by gruenesschaf
If you look at the charplan you'll see that all spells are of type Pet Spell, including FP, these spells are executed by the shade and once finished / as the effect of the cast will enqueue the listed sub spell with the necro pet. There are no special cases.
Sun 20 Oct 2019 8:28 PM by gruenesschaf
However, you are correct... kind of. As part of the necro rework to make it feel more responsive I decided to give it a queue size of 1 for spells with cast time and a separate queue of size 1 for instant cast spells, the cast time for those queues means the cast time of the spell that actually gets executed by the pet (most are instant except mana / life drain or the pbae etc.).

In your particular example where you "perfectly" time the healing spell completion with the activation of FP you are essentially overriding one of the instant spells with the other.

We have in general a 50ms game server tick rate, in currently popular wow terminology that means we have 50ms spell batching windows, the instant cast queue is processed each tick and the next instant cast spell is executed whenever the pet is currently not casting. That means if you have the pet cast a spell, cast the regen and then hit fp before the regen cast is done, then the regen cast finished before the pet is done casting you have essentially overwritten fp with the regen cast.

Return to Resolved Issues or the latest topics